From 753aa2ae47bcb09ea2455e2b3ed9043d43a1cbc8 Mon Sep 17 00:00:00 2001 From: Alexander Filippov Date: Sun, 27 Jun 2021 20:25:46 +0200 Subject: [PATCH] Fix git package updater --- Editor/PackageUpdater.cs | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/Editor/PackageUpdater.cs b/Editor/PackageUpdater.cs index 1e195d5..d3a0143 100644 --- a/Editor/PackageUpdater.cs +++ b/Editor/PackageUpdater.cs @@ -16,12 +16,14 @@ namespace Agoxandr.Utils } } - public static string GetStringBetweenCharacters(string input, char charFrom, char charTo) + public static string GetIdentifier(string input, char charFrom, char charTo) { - int posFrom = input.IndexOf(charFrom); + var first = input.IndexOf(charFrom); + var second = input.IndexOf(charTo, first + 1); + var posFrom = input.IndexOf(charFrom, second + 1); if (posFrom != -1) //if found char { - int posTo = input.IndexOf(charTo, posFrom + 1); + var posTo = input.IndexOf(charTo, posFrom + 1); if (posTo != -1) //if found char { return input.Substring(posFrom + 1, posTo - posFrom - 1); @@ -31,7 +33,7 @@ namespace Agoxandr.Utils return string.Empty; } - [MenuItem("Assets/Update Git Packages", false, 20)] + [MenuItem("Window/Package Manager/Update Git Packages", false, 1000)] private static void UpdateGitPackages() { var lines = File.ReadAllLines(ManifestPath); @@ -39,7 +41,7 @@ namespace Agoxandr.Utils { if (line.Contains("git")) { - var identifier = GetStringBetweenCharacters(line, '"', '"'); + var identifier = GetIdentifier(line, '"', '"'); Debug.Log("Checking for updates " + identifier); UnityEditor.PackageManager.Client.Add(identifier); }